linux-kernel - RE: [PATCH] USB: misc: Add N-trig firmware driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <6EF693376E00E2458E26FEC229232B128AAE23@Exchange2010-IL.n-trig.com>
Date:	Tue, 05 Oct 2010 06:59:43 +0000
From:	Micki Balanga <micki@...rig.com>
To:	Jiri Kosina <jkosina@...e.cz>, Greg KH <greg@...ah.com>
Cc:	"gregkh@...e.de" <gregkh@...e.de>,
	"jim.collar@...are.net" <jim.collar@...are.net>,
	"linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] USB: misc: Add N-trig firmware driver



> -----Original Message-----
> From: Jiri Kosina [mailto:jkosina@...e.cz]
> Sent: Monday, October 04, 2010 2:58 PM
> To: Greg KH
> Cc: Micki Balanga; gregkh@...e.de; jim.collar@...are.net; linux-
> usb@...r.kernel.org; linux-kernel@...r.kernel.org
> Subject: Re: [PATCH] USB: misc: Add N-trig firmware driver
> 
> On Sun, 3 Oct 2010, Greg KH wrote:
> 
> > >
> >
> > Can you please attach this in a non-base64 format so it can be
> properly
> > reviewed, and then, applied if applicable?
> >
> > Note, please run the patch through the scripts/checkpatch.pl tool
> first
> > before sending it out, so we don't just say the same things it finds
> :)
> 
> As we already have HID driver for n-trig, could this whole thing
> perhaps
> be made part of it?
> 
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.

The driver communicates with the bulk in/out endpoint. 

It was written as a standalone module, because it does not use any HID subsystem services, 
and to ensure that the HID driver would not be too complex. 

The driver has been tested over several weeks at our company.
The  patch was prepared and checked using the Checkpatch utility.

I await your input as to how you wish to proceed.
Micki

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/