linux-kernel - Re: [GIT PULL] core kernel fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101006045905.GE2553@linux.vnet.ibm.com>
Date:	Tue, 5 Oct 2010 21:59:05 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [GIT PULL] core kernel fixes

On Wed, Oct 06, 2010 at 04:56:54AM +0200, Eric Dumazet wrote:
> Le mardi 05 octobre 2010 à 15:05 -0700, Paul E. McKenney a écrit :
> > On Tue, Oct 05, 2010 at 02:45:07PM -0700, Linus Torvalds wrote:
> > > On Tue, Oct 5, 2010 at 2:09 PM, Paul E. McKenney
> > > <paulmck@...ux.vnet.ibm.com> wrote:
> > > >
> > > > Good point!!!  If the following diff looks good to you, I will get it
> > > > tested and pushed.
> > > 
> > > Looks good. Except since I pulled the thing despite my complaint,
> > > you'll also need to undo the extra irqs_disabled() test.
> > 
> > No problem, the diff I sent you combined two commits.  ;-)
> > 
> 
> Hi Paul & Linus
> 
> I originally considered adding the test in rcu_read_lock_bh_held() too,
> but thought (wrongly) :
> 
> 	"rcu_read_unlock_bh() doesnt block hard IRQ, thus
> 	 rcu_read_lock_bh_held() should not test hard irq."
> 
> I remember anyway my first patch was wrong, since I was not using
> irqs_disabled() but in_irq() 
> 
> http://kerneltrap.org/mailarchive/linux-kernel/2010/9/22/4622784

Eric,

I believe that history shows that we were all groping around in the
dark on this one...  Me not least of all.  ;-)

Not sure we are completely there yet, but we are at least in a
feasible state.

Ingo, I have this queued up at:

git://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-2.6-rcu.git rcu/urgent

It passes targeted testing.  If Eric is OK with it, it is ready to be
pulled.  At least as soon as kernel.org gets it out to the mirrors.
Commmit 773e3f9357.

							Thanx, Paul
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/