linux-kernel - Re: [PATCH v3] mips: irq: add stackoverflow detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CAC5537.9040904@mvista.com>
Date:	Wed, 06 Oct 2010 14:53:43 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Adam Jiang <jiang.adam@...il.com>
CC:	ralf@...ux-mips.org, linux-mips@...ux-mips.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] mips: irq: add stackoverflow detection

Hello.

On 06-10-2010 14:41, Adam Jiang wrote:

> Add stackoverflow detection to mips arch

    There's no such word: stackoverflow. Space is needed.

> This is the 3rd version of the smiple patch. 2K is too big for many
> system, so I Modified the warning line by following Ralf's suggestion.

> Signed-off-by: Adam Jiang<jiang.adam@...il.com>
[...]

> diff --git a/arch/mips/kernel/irq.c b/arch/mips/kernel/irq.c
> index c6345f5..b43edb7 100644
> --- a/arch/mips/kernel/irq.c
> +++ b/arch/mips/kernel/irq.c
> @@ -151,6 +151,28 @@ void __init init_IRQ(void)
>   #endif
>   }
>
> +#ifdef CONFIG_DEBUG_STACKOVERFLOW
> +static inline void check_stack_overflow(void)
> +{
> +	unsigned long sp;
> +
> +	asm volatile("move %0, $sp" : "=r" (sp));
> +	sp = sp & THREAD_MASK;

    Why not:

	sp &= THREAD_MASK;

    It's C, after all! :-)

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/