linux-kernel - Re: [PATCH 1/7] perf: Add helper function to return number of counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101006123521.GM13563@erda.amd.com>
Date:	Wed, 6 Oct 2010 14:35:21 +0200
From:	Robert Richter <robert.richter@....com>
To:	Matt Fleming <matt@...sole-pimps.org>
CC:	Peter Zijlstra <peterz@...radead.org>,
	Will Deacon <will.deacon@....com>,
	Paul Mundt <lethal@...ux-sh.org>,
	Russell King <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
	Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Deng-Cheng Zhu <dengcheng.zhu@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH 1/7] perf: Add helper function to return number of
 counters

On 06.10.10 14:14:10, Robert Richter wrote:
> On 04.10.10 16:44:19, Matt Fleming wrote:
> > The number of counters for the registered pmu is needed in a few places
> > so provide a helper function that returns this number.
> > 
> > Signed-off-by: Matt Fleming <matt@...sole-pimps.org>
> > Tested-by: Will Deacon <will.deacon@....com>
> > ---
> >  arch/arm/kernel/perf_event.c |    6 ++++++
> >  arch/arm/oprofile/common.c   |   31 ++++++++++++++++++-------------
> >  arch/sh/kernel/perf_event.c  |    9 +++++++++
> >  include/linux/perf_event.h   |    1 +
> >  4 files changed, 34 insertions(+), 13 deletions(-)

> > diff --git a/arch/arm/oprofile/common.c b/arch/arm/oprofile/common.c
> > index d660cb8..23f18a0 100644
> > --- a/arch/arm/oprofile/common.c
> > +++ b/arch/arm/oprofile/common.c
> > @@ -43,7 +43,7 @@ static DEFINE_MUTEX(op_arm_mutex);
> >  
> >  static struct op_counter_config *counter_config;
> >  static struct perf_event **perf_events[nr_cpumask_bits];
> > -static int perf_num_counters;
> > +static int perf_nr_counters;

Matt,

as we will have one more version with this patch set, please use
num_counters instead of perf_nr_counters. The same name is used also
for x86.

Thanks,

-Robert

> >  
> >  /*
> >   * Overflow callback for oprofile.

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/