linux-kernel - Re: [PATCH 2/5] Coccinelle: Improve user information with a new kind of comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CAC7123.8090504@suse.cz>
Date:	Wed, 06 Oct 2010 14:52:51 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Nicolas Palix <npalix.work@...il.com>
Cc:	Julia Lawall <julia@...u.dk>,
	Gilles Muller <Gilles.Muller@...6.fr>,
	Nicolas Palix <npalix@...u.dk>,
	Sam Ravnborg <sam@...nborg.org>,
	Joerg Roedel <joerg.roedel@....com>, cocci@...u.dk,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/5] Coccinelle: Improve user information with a new kind
 of comment

On 4.10.2010 22:45, Nicolas Palix wrote:
> Improve user information with a new kind of comment
> about semantic patch output.
> 
> Fix spelling.
> 
> Signed-off-by: Nicolas Palix <npalix.work@...il.com>
> Signed-off-by: Julia Lawall <julia@...u.dk>
> ---
>  scripts/coccicheck |    9 +++++++--
>  1 files changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/scripts/coccicheck b/scripts/coccicheck
> index b8bcf1f..4655551 100755
> --- a/scripts/coccicheck
> +++ b/scripts/coccicheck
> @@ -25,7 +25,7 @@ fi
>  
>  if [ "$MODE" = "" ] ; then
>      if [ "$ONLINE" = "0" ] ; then
> -	echo 'You have not explicitly specify the mode to use. Fallback to "report".'
> +	echo 'You have not explicitly specified the mode to use. Fallback to "report".'
>  	echo 'You can specify the mode with "make coccicheck MODE=<mode>"'
>  	echo 'Available modes are: report, patch, context, org'
>      fi
> @@ -52,7 +52,12 @@ coccinelle () {
>  
>  	FILE=`echo $COCCI | sed "s|$srctree/||"`
>  
> -	echo "Processing `basename $COCCI` with option(s) \"$OPT\""
> +	echo "Processing `basename $COCCI`"
> +	echo "with option(s) \"$OPT\""
> +	echo 'Semantic patch information:'
> +
> +	sed -e '/\/\/#/!d' -e 's|^//#||' $COCCI

sed -ne 's|^//#||p' $COCCI :)

But I would put this after the "Message example to submit a patch".
free.cocci has the information in this order and it makes more sense
this way IMO (first general information, then details). And it would be
nice to only display the "Semantic patch information:" line if there
actually is some additional information in the semantic patch file.
Otherwise, the series looks OK to me.

> +
>  	echo 'Message example to submit a patch:'
>  
>  	sed -e '/\/\/\//!d' -e 's|^///||' $COCCI


Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/