linux-kernel - Re: [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate init/exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101006145903.GR13563@erda.amd.com>
Date:	Wed, 6 Oct 2010 16:59:03 +0200
From:	Robert Richter <robert.richter@....com>
To:	Paul Mundt <lethal@...ux-sh.org>
CC:	Matt Fleming <matt@...sole-pimps.org>,
	Will Deacon <will.deacon@....com>,
	Russell King <linux@....linux.org.uk>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"linux-sh@...r.kernel.org" <linux-sh@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Ingo Molnar <mingo@...e.hu>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	"linux-arch@...r.kernel.org" <linux-arch@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Deng-Cheng Zhu <dengcheng.zhu@...il.com>,
	Grant Likely <grant.likely@...retlab.ca>
Subject: Re: [PATCH 4/7] ARM: oprofile: Move non-ARM code into separate
 init/exit

On 06.10.10 10:53:11, Paul Mundt wrote:
> On Wed, Oct 06, 2010 at 04:49:21PM +0200, Robert Richter wrote:
> > On 06.10.10 15:33:09, Robert Richter wrote:
> > > On 04.10.10 16:44:22, Matt Fleming wrote:
> > > > -void __exit oprofile_arch_exit(void)
> > > > +int __init oprofile_arch_init(struct oprofile_operations *ops)
> > > > +{
> > > 
> > > We should do here a:
> > > 
> > > 	memset(ops, 0, sizeof(*ops));
> > 
> > Matt,
> > 
> > an alternative would be to move this to oprofile_perf_init() and
> > modify ops->backtrace afterwards, but then we will lose the function's
> > tail call. Not sure that is better. Paul, what do you think?
> > 
> I'm a bit confused as to why we just don't do:
> 
> ---
> 
> diff --git a/drivers/oprofile/oprof.c b/drivers/oprofile/oprof.c
> index b336cd9..76d97a5 100644
> --- a/drivers/oprofile/oprof.c
> +++ b/drivers/oprofile/oprof.c
> @@ -252,6 +252,8 @@ static int __init oprofile_init(void)
>  {
>  	int err;
>  
> +	memset(&oprofile_ops, 0, sizeof(struct oprofile_operations));
> +

Yes, this looks much better. Thanks Paul.

-Robert

>  	err = oprofile_arch_init(&oprofile_ops);
>  	if (err < 0 || timer) {
>  		printk(KERN_INFO "oprofile: using timer interrupt.\n");
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/