linux-kernel - Re: [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl has 4 warnings and 0 errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CACB7C3.9030000@caviumnetworks.com>
Date:	Wed, 06 Oct 2010 10:54:11 -0700
From:	David Daney <ddaney@...iumnetworks.com>
To:	Tracey Dent <tdent48227@...il.com>
CC:	greg@...ah.com, abbotti@....co.uk, fmhess@...rs.sourceforge.net,
	kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/28] Staging: comedi: drivers.c: Edit file so that checkpatch.pl
 has 4 warnings and 0 errors

On 10/05/2010 06:00 PM, Tracey Dent wrote:
> Changed a few lines that made checkpatch.pl complain. Could not get ever warning but
> I got it down to to just 4, WARNING: line over 80 characters.

The overall goal is to improve the code, not placate checkpatch.pl

[...]
>   				printk
> -				    (KERN_WARNING "BUG! detaching device with use_count=%d\n",
> -				     dev->use_count);
> +				    (KERN_WARNING "BUG! detaching device     \
> +							with use_count=%d\n",
> +							dev->use_count);

Is that really an improvement?

And even if it were, is that really how strings should be split up?

Hint:
	pr_warning("BUG! detaching device with use_count=%d\n",
		   dev->use_count);


David Daney
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/