linux-kernel - Re: [GIT PULL] one writeback regression fix for .36

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=NkzSWR0voR9xLs2f7Rxfc4A_n7qi+t9fbB2iz@mail.gmail.com>
Date:	Wed, 6 Oct 2010 11:17:54 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Jens Axboe <jaxboe@...ionio.com>, Christoph Hellwig <hch@....de>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] one writeback regression fix for .36

On Wed, Oct 6, 2010 at 9:54 AM, Jens Axboe <jaxboe@...ionio.com> wrote:
>
> The recent patch series from Jan introduced a WARN_ON() regression.
> The real fix for this is adding a super_operations->get_bdi(), which
> we'll do for 2.6.37.
>
> Please pull.
>
> are available in the git repository at:
>  git://git.kernel.dk/linux-2.6-block.git for-linus
>
> Christoph Hellwig (1):
>      writeback: always use sb->s_bdi for writeback purposes

This is a f*cking disgrace. It's now the second patch I see during
this release window that works by parsing random strings in the block
device layer.

This needs to stop. There's something seriously wrong in the whole
subsystem. This kind of hackery is a disease, and it seems to be
endemic.

So let's just make sure that 2.6.37 really does clean these things up.
And dammit, I don't want to see more random crap added. There has been
too much crazyness going on, with too little taste in the whole
writeback and IO scheduler area. Jens, you need to put the brakes on.
No more crap. Really. Make 2.6.37 a stabilization and cleanup release,
without new crazy features or clever tweaking. Ok? Because writeback
was a disaster in 2.6.35, and it's been this kind of crazy ugly in
2.6.36.

So I'm not taking any more writeback changes unless I feel that you
are actively working on cleaning up the crazy tasteless crap without
adding new code.

                     Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/