linux-kernel - Re: [GIT PULL] one writeback regression fix for .36

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 6 Oct 2010 20:43:53 +0200
From:	Christoph Hellwig <hch@....de>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jens Axboe <jaxboe@...ionio.com>,
	Christoph Hellwig <hch@....de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] one writeback regression fix for .36

On Wed, Oct 06, 2010 at 07:31:24PM +0100, Al Viro wrote:
> Eh...  I'm no fonder of that than you are (and strcmp is fucking stupid),
> but... that thing is really sb_is_blkdev_sb() trying to make a comeback
> in fs/fs-writeback.c.  IOW, it's sick, but not for the reasons you are
> mentioning; strcmp() use is trivially removable.

The alternative basically is exporting bd_type so that it can be used
here and comparing ->s_type.  The real problem is that right now the
internal block device filesystem is the only one having more than one
backing device per filesystem.  I have patches to generalize that, which
is something we'll need for writeback performance on large filesystem
sooner or later.  I was planning to get this ready for 2.6.37, but if
you prefer no big chance in this area I can calm down and move other
things up on my TODO list.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/