linux-kernel - Re: [RESEND PATCH 1/2] IRQ: use cpu_possible_mask rather than online_mask in setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101006210236.GQ13726@us.ibm.com>
Date:	Wed, 6 Oct 2010 16:02:36 -0500
From:	Sonny Rao <sonnyrao@...ibm.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	Nishanth Aravamudan <nacc@...ibm.com>, miltonm@....com,
	Thomas Gleixner <tglx@...utronix.de>,
	Ian Campbell <ian.campbell@...rix.com>,
	Peter P Waskiewicz Jr <peter.p.waskiewicz.jr@...el.com>,
	linux-kernel@...r.kernel.org, sonnyrao@...ux.vnet.ibm.com
Subject: Re: [RESEND PATCH 1/2] IRQ: use cpu_possible_mask rather than
 online_mask in setup_affinity

On Sat, Oct 02, 2010 at 01:01:02PM +0200, Peter Zijlstra wrote:
> On Fri, 2010-10-01 at 14:26 -0700, Nishanth Aravamudan wrote:
> > The use of online_mask requires architecture code to be hotplug-aware to
> > account for IRQ round-robin'ing. 
> 
> Architectures that support hotplug should be hotplug aware, that's not
> too much to ask imho.

It seems like most architectures support HOTPLUG_CPU
a quick grep for HOTPLUG_CPU in arch shows:
arm
blackfin
ia64
m32r
mips
mn10300
parisc
powerpc
s390
sh
sparc
x86

also see my reply to Thomas -- it appears that many of the interrupt
controller implementations enforce only affinitizing to online cpus

The other point is, as this is generic code, it's making an assumption
that online cpus is the right mask to test against and we know of at
least one case where this isn't quite correct.

> > With user-driven dynamic SMT,
> 
> What's that?

Well, that is basically a feature where we can use CPU hotplug to
force a particular mode on an SMT (hardware multithreaded) processor 

The point here was really that on such multi-threaded processors -- which are
becoming more common -- cpu hotplug can potentially be used fairly
often.


Sonny
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/