linux-kernel - Re: [PATCH] staging: fix possible use-before-NULL-check crash

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101006225104.GA21013@suse.de>
Date:	Wed, 6 Oct 2010 15:51:04 -0700
From:	Greg KH <gregkh@...e.de>
To:	Kees Cook <kees.cook@...onical.com>
Cc:	linux-kernel@...r.kernel.org, devel@...verdev.osuosl.org,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Stefan Ringel <stefan.ringel@...or.de>,
	Stephen Rothwell <sfr@...b.auug.org.au>
Subject: Re: [PATCH] staging: fix possible use-before-NULL-check crash

On Wed, Oct 06, 2010 at 03:39:41PM -0700, Kees Cook wrote:
> Found via http://coccinelle.lip6.fr/rules/mini_null_ref.cocci
> 
> Signed-off-by: Kees Cook <kees.cook@...onical.com>
> ---
>  drivers/staging/tm6000/tm6000-alsa.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/staging/tm6000/tm6000-alsa.c b/drivers/staging/tm6000/tm6000-alsa.c
> index 087137d..c1aff0e 100644
> --- a/drivers/staging/tm6000/tm6000-alsa.c
> +++ b/drivers/staging/tm6000/tm6000-alsa.c
> @@ -426,10 +426,11 @@ error:
>  
>  static int tm6000_audio_fini(struct tm6000_core *dev)
>  {
> -	struct snd_tm6000_card	*chip = dev->adev;
> +	struct snd_tm6000_card	*chip;
>  
>  	if (!dev)
>  		return 0;
> +	chip = dev->adev;

Nice catch, but I don't think that the dev pointer can ever be NULL
here.

Mauro, can you queue this up through your tree, as you handle this one?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/