linux-kernel - Re: [PATCHv4] ARM: imx: Add iram allocator functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <19629.33589.158235.949280@ipc1.ka-ro>
Date:	Thu, 7 Oct 2010 10:22:13 +0200
From:	Lothar Waßmann <LW@...O-electronics.de>
To:	<Dinh.Nguyen@...escale.com>
Cc:	<linux-kernel@...r.kernel.org>, amit.kucheria@...onical.com,
	linux@....linux.org.uk, s.hauer@...gutronix.de,
	bryan.wu@...onical.com, grant.likely@...retlab.ca,
	linux-arm-kernel@...ts.infradead.org, daniel@...aq.de,
	u.kleine-koenig@...gutronix.de, xiao-lizhang@...escale.com,
	valentin.longchamp@...l.ch
Subject: Re: [PATCHv4] ARM: imx: Add iram allocator functions

Hi,

[...]
> +void __iomem*iram_alloc(unsigned int size, unsigned long *dma_addr)
> +{
> +	if (!iram_pool)
> +		return NULL;
> +
> +	*dma_addr = gen_pool_alloc(iram_pool, size);
> +	pr_debug("iram alloc - %dB@...p\n", size, (void *)*dma_addr);
why not:
| +	pr_debug("iram alloc - %dB@...8lx\n", size, *dma_addr);

> +	if (!dma_addr)
>
This will never be true (unless someone passes a NULL pointer as
dma_addr).
| +	if (!*dma_addr)
was obviously meant here.


Lothar Waßmann
-- 
___________________________________________________________

Ka-Ro electronics GmbH | Pascalstraße 22 | D - 52076 Aachen
Phone: +49 2408 1402-0 | Fax: +49 2408 1402-10
Geschäftsführer: Matthias Kaussen
Handelsregistereintrag: Amtsgericht Aachen, HRB 4996

www.karo-electronics.de | info@...o-electronics.de
___________________________________________________________
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/