linux-kernel - Re: [GIT PULL] single block fix for 2.6.36

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <x49lj6a9i3x.fsf@segfault.boston.devel.redhat.com>
Date:	Thu, 07 Oct 2010 10:45:38 -0400
From:	Jeff Moyer <jmoyer@...hat.com>
To:	Jens Axboe <jaxboe@...ionio.com>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [GIT PULL] single block fix for 2.6.36

Jens Axboe <jaxboe@...ionio.com> writes:

> Hi Linus,
>
> The API that was added for drivers to switch IO schedulers
> when loaded does not work if the driver isn't in a fully
> initialized state. The in-kernel ones call it right after
> blk_init_queue(), which will result in an oops when the
> elevator core tries to unregister unregistered kobjects.

Color me confused.  If the problem is trying to unregister unregistered
objects, then why does your backtrace show a problem registering
objects?

    RIP: 0010:[<ffffffff8116f15e>]  [<ffffffff8116f15e>] sysfs_create_dir+0x2e/0xc0
...
    Call Trace:
     [<ffffffff8123fb77>] kobject_add_internal+0xe7/0x1f0
     [<ffffffff8123fd98>] kobject_add_varg+0x38/0x60
     [<ffffffff8123feb9>] kobject_add+0x69/0x90
     [<ffffffff8116efe0>] ? sysfs_remove_dir+0x20/0xa0
     [<ffffffff8103d48d>] ? sub_preempt_count+0x9d/0xe0
     [<ffffffff8143de20>] ? _raw_spin_unlock+0x30/0x50
     [<ffffffff8116efe0>] ? sysfs_remove_dir+0x20/0xa0
     [<ffffffff8116eff4>] ? sysfs_remove_dir+0x34/0xa0
     [<ffffffff81224204>] elv_register_queue+0x34/0xa0
     [<ffffffff81224aad>] elevator_change+0xfd/0x250
     [<ffffffffa007e000>] ? t_init+0x0/0x361 [t]
     [<ffffffffa007e000>] ? t_init+0x0/0x361 [t]
     [<ffffffffa007e0a8>] t_init+0xa8/0x361 [t]
     [<ffffffff810001de>] do_one_initcall+0x3e/0x170
     [<ffffffff8108c3fd>] sys_init_module+0xbd/0x220
     [<ffffffff81002f2b>] system_call_fastpath+0x16/0x1b

I tried to track down what was going on, but I don't have your .config,
so trying to pick things apart by guessing wasn't working out very well
for me.  Also, your changelog entry in your tree is different from what
you posted here (more complete) and you never posted a relevant patch to
the list.

> Add a registered bit and only do the unregister/register
> dance in elevator_switch() if we need to. The other call
> path for this is the sysfs parts to allow online switching,
> which can only be called with a fully setup driver.

I don't doubt that you're right, but you certainly haven't given enough
information for me to verify this in the 20 or 30 minutes I spent
looking.

Cheers,
Jeff
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/