linux-kernel - RE: [PATCH 1/2] drivers:bluetooth: TI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1286464659.6145.144.camel@aeonflux>
Date:	Thu, 07 Oct 2010 17:17:39 +0200
From:	Marcel Holtmann <marcel@...tmann.org>
To:	"Savoy, Pavan" <pavan_savoy@...com>
Cc:	"linux-bluetooth@...r.kernel.org" <linux-bluetooth@...r.kernel.org>,
	"johan.hedberg@...il.com" <johan.hedberg@...il.com>,
	"greg@...ah.com" <greg@...ah.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 1/2] drivers:bluetooth: TI_ST bluetooth driver

Hi Pavan,

> > Registering the Bluetooth HCI driver in module_init/module_exit is not
> > acceptable. Turn your shared transport into a proper bus.
> 
> Yes, you did comment on it before, I remember, I did prototype the driver as
> a bus driver, However I didn't find any advantages by converting it to a bus
> driver.
> As in, currently the shared transport driver is a line discipline driver because
> it is the only way it can communicate over TTY without being tightly coupled with the UART driver.
> 
> > We want to be able to have generic kernels where this module is enabled,
> > but no Shared Transport is available.
> 
> Oh if this is the reason I cannot have hci_register/_unregister in module_init/_exit, Can I do this module "depends" on TI_ST, Then it would not
> even be visible to build if TI_ST is not selected.

this is not helping either. Then TI_ST can not be selected and so you
still end up with some weird platform specific kernels. We don't want
that. We want generic kernels that can detect the hardware they are
running on.

As I said, I will not accept this driver if it registers HCI device in
module_init. No other driver is doing this and it is in general a really
really really bad idea.

Regards

Marcel


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/