linux-kernel - Re: [PATCH] kobject: name reference should not be lost when lack of memory error happens

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101007175303.GB31639@kroah.com>
Date:	Thu, 7 Oct 2010 10:53:03 -0700
From:	Greg KH <greg@...ah.com>
To:	Roman Tereshonkov <roman.tereshonkov@...ia.com>,
	Kay Sievers <kay.sievers@...y.org>
Cc:	linux-kernel@...r.kernel.org, gregkh@...e.de
Subject: Re: [PATCH] kobject: name reference should not be lost when lack
 of memory error happens

On Thu, Oct 07, 2010 at 01:32:53PM +0300, Roman Tereshonkov wrote:
> If lack of memory error happens we must restore the old kobject name reference

No, we can't do that, as the caller will not be expecting that to have
happened, right Kay?

I think the code as-is is correct, your kobject is in an unknown state
and can't be used anymore.

thanks,

greg k-h

> Signed-off-by: Roman Tereshonkov <roman.tereshonkov@...ia.com>
> ---
>  lib/kobject.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/lib/kobject.c b/lib/kobject.c
> index f07c572..c5cb117 100644
> --- a/lib/kobject.c
> +++ b/lib/kobject.c
> @@ -222,8 +222,10 @@ int kobject_set_name_vargs(struct kobject *kobj, const char *fmt,
>  		return 0;
>  
>  	kobj->name = kvasprintf(GFP_KERNEL, fmt, vargs);
> -	if (!kobj->name)
> +	if (!kobj->name) {
> +		kobj->name = old_name;
>  		return -ENOMEM;
> +	}
>  
>  	/* ewww... some of these buggers have '/' in the name ... */
>  	while ((s = strchr(kobj->name, '/')))
> -- 
> 1.7.0.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/