linux-kernel - Re: [PATCH 3/4] mfd/mc13xxx: add support for mc13892

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101007184501.GX29673@pengutronix.de>
Date:	Thu, 7 Oct 2010 20:45:01 +0200
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	Samuel Ortiz <sameo@...ux.intel.com>,
	David Jander <david@...tonic.nl>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/4] mfd/mc13xxx: add support for mc13892

Hi Samuel,

On Wed, Sep 29, 2010 at 06:23:46PM +0200, Uwe Kleine-König wrote:
> mc13892 is the companion PMIC for Freescale's i.MX51.  It's similar enough
> to mc13782 to support it in a single driver.
> 
> This patch introduces enough compatibility cruft to keep all users of the
> superseded mc13783 driver unchanged.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
> ---
>  drivers/mfd/Kconfig         |    9 +-
>  drivers/mfd/Makefile        |    2 +-
>  drivers/mfd/mc13783-core.c  |  743 --------------------------------------
>  drivers/mfd/mc13xxx-core.c  |  840 +++++++++++++++++++++++++++++++++++++++++++
>  include/linux/mfd/mc13783.h |  247 ++++++-------
>  include/linux/mfd/mc13xxx.h |  154 ++++++++
>  6 files changed, 1113 insertions(+), 882 deletions(-)
>  delete mode 100644 drivers/mfd/mc13783-core.c
>  create mode 100644 drivers/mfd/mc13xxx-core.c
>  create mode 100644 include/linux/mfd/mc13xxx.h
> 
> [...]
> diff --git a/drivers/mfd/mc13xxx-core.c b/drivers/mfd/mc13xxx-core.c
> new file mode 100644
> index 0000000..93258ad
> --- /dev/null
> +++ b/drivers/mfd/mc13xxx-core.c
> @@ -0,0 +1,840 @@
> +/*
> + * Copyright 2009-2010 Pengutronix
> + * Uwe Kleine-Koenig <u.kleine-koenig@...gutronix.de>
> + *
> + * loosely based on an earlier driver that has
> + * Copyright 2009 Pengutronix, Sascha Hauer <s.hauer@...gutronix.de>
> + *
> + * This program is free software; you can redistribute it and/or modify it under
> + * the terms of the GNU General Public License version 2 as published by the
> + * Free Software Foundation.
> + */
> +#define DEBUG
> +#define VERBOSE_DEBUG
David Jander gave me a hint via private mail that I forgot to remove
these two #defines.
Would you care to remove these before Linus pulls?  Should I send a
patch or do you do it by hand?

Thanks to both of you,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/