linux-kernel - RE: [PATCH v5] staging: iio: light: Adding driver for ISL29018 ALS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E88A1D35AF5437468E5B14C7C4BA61C702D37C9E9C@HQMAIL01.nvidia.com>
Date:	Thu, 7 Oct 2010 15:39:02 -0700
From:	Rhyland Klein <rklein@...dia.com>
To:	Greg KH <greg@...ah.com>
CC:	"jic23@....ac.uk" <jic23@....ac.uk>,
	"joe@...ches.com" <joe@...ches.com>,
	Andrew Chew <AChew@...dia.com>,
	"olof@...om.net" <olof@...om.net>,
	"linux-i2c@...r.kernel.org" <linux-i2c@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	Laxman Dewangan <ldewangan@...dia.com>
Subject: RE: [PATCH v5] staging: iio: light: Adding driver for ISL29018 ALS

Sorry resending new patch (compiles fine for me).

> -----Original Message-----
> From: Greg KH [mailto:greg@...ah.com]
> Sent: Thursday, October 07, 2010 2:42 PM
> To: Rhyland Klein
> Cc: jic23@....ac.uk; joe@...ches.com; Andrew Chew; olof@...om.net; linux-
> i2c@...r.kernel.org; linux-kernel@...r.kernel.org; linux-
> iio@...r.kernel.org; Laxman Dewangan
> Subject: Re: [PATCH v5] staging: iio: light: Adding driver for ISL29018 ALS
> 
> On Thu, Oct 07, 2010 at 12:48:03PM -0700, rklein@...dia.com wrote:
> > From: Rhyland Klein <rklein@...dia.com>
> >
> > adding support for the ISL 29018 ambient light and proximity sensor.
> >
> > Addressed comments from reviews by Jonathan Cameron and Joe Perches
> >   * Removed some excess dbg prints that only printed function name
> >   * Renamed some properties to make them more descriptive
> >   * Added a property to list available adc resolutions
> >   * Defined arrays for resolutions/ranges as static const
> >   * Change loops initialization to memset for extensibility.
> >     * used sizeof() instead of ARRAY_SIZE() to be safer
> >   * Added a property to list available adc ranges
> >
> > Signed-off-by: Rhyland Klein <rklein@...dia.com>
> > Acked-by: Jonathan Cameron <jic23@....ac.uk>
> 
> Too bad no one actually compiled this driver:
>   CC [M]  drivers/staging/iio/light/isl29018.o
> drivers/staging/iio/light/isl29018.c:420:8: error:
> ‘show_prox_infrared_suppression’ undeclared here (not in a function)
> drivers/staging/iio/light/isl29018.c:433:1: error:
> ‘iio_dev_attr_range_available’ undeclared here (not in a function)
> drivers/staging/iio/light/isl29018.c:435:1: error:
> ‘iio_dev_attr_adc_resolution_available’ undeclared here (not in a function)
> drivers/staging/iio/light/isl29018.c: In function ‘isl29018_chip_init’:
> drivers/staging/iio/light/isl29018.c:451:6: warning: unused variable ‘i’
> drivers/staging/iio/light/isl29018.c: At top level:
> drivers/staging/iio/light/isl29018.c:350:16: warning:
> ‘show_prox_infrared_supression’ defined but not used
> drivers/staging/iio/light/isl29018.c:416:1: warning:
> ‘iio_const_attr_range_available’ defined but not used
> drivers/staging/iio/light/isl29018.c:417:1: warning:
> ‘iio_const_attr_adc_resolution_available’ defined but not used
> make[2]: *** [drivers/staging/iio/light/isl29018.o] Error 1
> make[1]: *** [drivers/staging/iio/light] Error 2
> make: *** [_module_drivers/staging/iio] Error 2
> 
> Please fix this up before resending it.
> 
> thanks,
> 
> greg k-h