linux-kernel - Re: [PATCH 15/22] x86: Copy-n-paste arch_teardown_msi_irqs from msi.c to io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101007025750.GA8272@dumpdata.com>
Date:	Wed, 6 Oct 2010 22:57:50 -0400
From:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	linux-kernel@...r.kernel.org, xen-devel@...ts.xensource.com,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Jesse Barnes <jbarnes@...tuousgeek.org>
Subject: Re: [PATCH 15/22] x86: Copy-n-paste arch_teardown_msi_irqs from
 msi.c to io_apic.c.

On Wed, Oct 06, 2010 at 09:09:13PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Oct 05, 2010 at 11:07:36AM +0200, Thomas Gleixner wrote:
> > On Mon, 4 Oct 2010, Konrad Rzeszutek Wilk wrote:
> > 
> > > In preparation for non-privileged domains to disable PCI devices'
> > > MSI/MSIx, we need to augment arch_teardown_msi_irqs to make
> > > a call to the privileged domain (patch to follow).
> > 
> > Can't we find a more clever solution than just copying stuff around ?
> 
> Thanks for suggestion. Based on your idea, this is the patch I've rigged up.
> I've also included a different re-implementation of the next patch
> that would utilize this (x86-Introduce-x86_msi_ops). Tested successfully on x86.
> Cross-compiling on PPC, PPC64, and IA64 shows no failure.

But I did find that playing with 'make randconfig' where I got:
# CONFIG_PCI not set

produces interesting errors. So attached is the second patch, but
hardned against the case of building an X86 kernel without PCI support.

The patches are also available at:
git://git.kernel.org/pub/scm/linux/kernel/git/konrad/xen.git devel/xen-pcifront-0.8



View attachment "0001-x86-Introduce-x86_msi_ops.patch" of type "text/x-diff" (4649 bytes)