linux-kernel - Re: [PATCH 2/2] apic, x86: Use BIOS settings for IBS and MCE threshold interrupt LVT offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101008102115.GG13563@erda.amd.com>
Date:	Fri, 8 Oct 2010 12:21:15 +0200
From:	Robert Richter <robert.richter@....com>
To:	Cyrill Gorcunov <gorcunov@...il.com>
CC:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 2/2] apic, x86: Use BIOS settings for IBS and MCE
 threshold interrupt LVT offsets

On 08.10.10 05:37:24, Cyrill Gorcunov wrote:
> On Fri, Oct 8, 2010 at 1:24 PM, Robert Richter <robert.richter@....com> wrote:
> ...
> >> > +                   } else if (lvt_off != offset) {
> >>
> >> Could we put explicit type specificator here? For better readbility.
> >> ...
> >
> > Cyrill,
> >
> > Do you mean an explicit type cast here, or something else?
> >
> 
> Yeah, explicit type cast (not a big deal though since at moment
> of course nothing can fire in this snippet, but I think for future
> modifications better to have explicit cast).

Hmm, don't think this is really necessary. As an alternative we could
make variable offset an int too and then do an explicit cast when
calling setup_APIC_eilvt().

But I rather tend to leave it as it is.

-Robert

> 
> >
> > Thanks for review,
> >
> > -Robert
> >
> 
> Cyrill
> 

-- 
Advanced Micro Devices, Inc.
Operating System Research Center

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/