lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTim=kmzwV+S-aP3+B1CNkS_XrvHuEewpmYZZtcA9@mail.gmail.com>
Date:	Fri, 8 Oct 2010 21:46:50 +1000
From:	Dave Airlie <airlied@...il.com>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Keith Packard <keithp@...thp.com>
Subject: Re: "do_IRQ: 0.89 No irq handler for vector (irq -1)"

On Fri, Oct 8, 2010 at 5:52 PM, Thomas Gleixner <tglx@...utronix.de> wrote:
> On Thu, 7 Oct 2010, Thomas Gleixner wrote:
>  Oct  7 23:21:24 ionos kernel: Console: switching to colour VGA+ 80x25
>> Oct  7 23:21:31 ionos kernel: drm: unregistered panic notifier
>> Oct  7 23:21:31 ionos kernel: vga_switcheroo: disabled
>> Oct  7 23:21:31 ionos kernel: [drm:drm_mm_takedown] *ERROR* Memory manager not clean. Delaying takedown
>>
>> That one scares me :)
>>
>> Oct  7 23:21:32 ionos kernel: BUG: unable to handle kernel paging request at 00000037362e313a
>>
>> We are again dereferencing a user space address.
>
> Further debugging shows that the interrupt is torn down and the
> vectors are cleared. On modprobe the irq is set up again and a
> different vector is assigned.
>
> The interrupt which comes in is going to the old vector. So something
> is stale in the card.

Okay I've traced it with the hints Thomas gave me,

What happens is we have never called pci_disable_device on video
devices for various reasons, like shutting down VGA devices could be
hostile,

however on rmmod of the driver the PCI layer sets the device power
state to PCI_UNKNOWN, when we next load the driver we call
pci_enable_device
which sees the enable cnt is 1, so never calls
pci_set_power_state(PCI_D0), the MSI code won't actually write MSI
msgs unless it knows we are in D0.

Not sure how best to fix, I can workaround by calling
pci_set_power_state(PCI_D0) in the drm drivers, but I sorta thing the
PCI layer should take care of this.

Dave.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ