linux-kernel - Re: [PATCH] kvm: add oom notifier for virtio balloon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101008130916.GC5327@balbir.in.ibm.com>
Date:	Fri, 8 Oct 2010 18:39:16 +0530
From:	Balbir Singh <balbir@...ux.vnet.ibm.com>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	kvm@...r.kernel.org, linux-kernel@...r.kernel.org, avi@...hat.com,
	Rusty Russell <rusty@...tcorp.com.au>,
	Anthony Liguori <anthony@...emonkey.ws>
Subject: Re: [PATCH] kvm: add oom notifier for virtio balloon

* Dave Young <hidave.darkstar@...il.com> [2010-10-05 20:45:21]:

> Balloon could cause guest memory oom killing and panic.
> 
> Add oom notify to leak some memory and retry fill balloon after 5 minutes.
> 
> At the same time add a mutex to protect balloon operations
> because we need leak balloon in oom notifier and give back freed value. 
> 
> Thanks Anthony Liguori for his sugestion about inflate retrying.
> Sometimes it will cause endless inflate/oom/delay loop,
> so I think next step is to add an option to do noretry-when-oom balloon.
> 
> Signed-off-by: Dave Young <hidave.darkstar@...il.com>

Won't __GFP_NORETRY prevent OOM? Could you please describe how you
tested the patch?

-- 
	Three Cheers,
	Balbir
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/