linux-kernel - Re: linux-next: build warnings after merge of the kbuild-current tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CAF3356.8080103@suse.cz>
Date:	Fri, 08 Oct 2010 17:05:58 +0200
From:	Michal Marek <mmarek@...e.cz>
To:	Américo Wang <xiyou.wangcong@...il.com>
Cc:	Catalin Marinas <catalin.marinas@....com>,
	Stephen Rothwell <sfr@...b.auug.org.au>,
	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Arnaud Lacombe <lacombar@...il.com>
Subject: Re: linux-next: build warnings after merge of the kbuild-current
 tree

On 8.10.2010 17:03, Américo Wang wrote:
> On Fri, Oct 08, 2010 at 04:51:41PM +0200, Michal Marek wrote:
>>
>>>From ca22d6b4c7c26a8ff9092036a9524bc5ba817277 Mon Sep 17 00:00:00 2001
>> From: Michal Marek <mmarek@...e.cz>
>> Date: Fri, 8 Oct 2010 16:40:27 +0200
>> Subject: [PATCH] kconfig: Temporarily disable dependency warnings
>>
>> After fixing a use-after-free bug in kconfig, a 'make defconfig' or
>> 'make allmodconfig' fills the screen with warnings that were not
>> detected before. Given that we are close to the release now, disable the
>> warnings temporarily and deal with them after 2.6.36.
>>
>> Signed-off-by: Michal Marek <mmarek@...e.cz>
>>
>> diff --git a/scripts/kconfig/symbol.c b/scripts/kconfig/symbol.c
>> index 943712c..d3cfa49 100644
>> --- a/scripts/kconfig/symbol.c
>> +++ b/scripts/kconfig/symbol.c
>> @@ -350,7 +350,7 @@ void sym_calc_value(struct symbol *sym)
>> 				}
>> 			}
>> 		calc_newval:
>> -			if (sym->dir_dep.tri == no && sym->rev_dep.tri != no) {
>> +			if (0 && sym->dir_dep.tri == no && sym->rev_dep.tri != no) {
>> 				fprintf(stderr, "warning: (");
>> 				expr_fprint(sym->rev_dep.expr, stderr);
>> 				fprintf(stderr, ") selects %s which has unmet direct dependencies (",
> 
> Well, this is an odd way to comment a block of code out,
> usually we use #ifdef 0 instead. :)

Right, but that's a tiny technical detail now :).

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/