linux-kernel - Re: [RFC/PATCH v3] usb: usb3.0 ch9 definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101008150954.GA18531@linux.intel.com>
Date:	Fri, 8 Oct 2010 11:09:54 -0400
From:	Matthew Wilcox <willy@...ux.intel.com>
To:	Brokhman Tatyana <tlinder@...eaurora.org>
Cc:	Greg KH <gregkh@...e.de>, linux-usb@...r.kernel.org,
	linux-arm-msm@...r.kernel.org,
	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH v3] usb: usb3.0 ch9 definitions

On Fri, Oct 08, 2010 at 05:35:40AM -0700, Brokhman Tatyana wrote:
> >> + */
> >> +#define USB_DEVICE_U1_ENABLE	48	/* dev may initiate U1 transition */
> >> +#define USB_DEVICE_U2_ENABLE	49	/* dev may initiate U2 transition*/
> >> +#define USB_DEVICE_LTM_ENABLE	50	/* dev may send LTM*/
> >> +#define USB_INTRF_FUNC_SUSPEND	0	/* function suspend*/

Missing space before the '*/' on these three lines.

> > __le16?  I'm guessing these fields haven't actually been used for
> > anything?
> 
> Actually __bU2DevExitLat is not bitwise field so it can remain __u16. And
> no, their values have been used for nothing but testing the descriptor.

The __le16 isn't about bitfields.  It's about the fact that the bytes
are stored in little-endian form.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/