linux-kernel - Re: [PATCH 6/6] intel_mid_dma: change the slave interface

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=8dV1EaAsT-Gkjkb-UY9R10r8LFQxMK3xQOwDw@mail.gmail.com>
Date:	Fri, 8 Oct 2010 10:27:53 -0700
From:	Dan Williams <dan.j.williams@...el.com>
To:	Vinod Koul <vinod.koul@...el.com>
Cc:	linux-kernel@...r.kernel.org, alan@...ux.intel.com,
	ramesh.b.k.v@...el.com, yong.y.wang@...ux.intel.com
Subject: Re: [PATCH 6/6] intel_mid_dma: change the slave interface

On Mon, Oct 4, 2010 at 3:38 AM, Vinod Koul <vinod.koul@...el.com> wrote:
> In 2.6.36 kernel, dma slave control command was introduced,
> this patch changes the intel-mid-dma driver to this
> new kernel slave interface
>
> Signed-off-by: Vinod Koul <vinod.koul@...el.com>
> ---
[..]
> +static int dma_slave_control(struct dma_chan *chan, unsigned long arg)
> +{
> +       struct intel_mid_dma_chan       *midc = to_intel_mid_dma_chan(chan);
> +       struct dma_slave_config  *slave = (struct dma_slave_config *)arg;
> +       struct intel_mid_dma_slave *mid_slave;
> +
> +       BUG_ON(!midc);
> +       BUG_ON(!slave);
> +       pr_debug("MDMA: slave control called\n");
> +
> +       mid_slave = to_intel_mid_dma_slave(slave);

I know this was the initial recommendation to support custom
extensions to dma_slave_config, but this isn't safe.  How does this
routine know that that 'slave' is embedded in an intel_mid_dma_slave
structure.  I applied it as is, but I think we need a better approach.

Maybe a per device alloc_dma_slave_config() such that ->dma_control()
can assume the driver allocated the dma_slave_config.  As it stands
nothing in the calling convention guarantees type safety.

--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/