linux-kernel - Re: [PATCH v6 07/12] Add async PF initialization to PV guest.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CB0B803.3040008@redhat.com>
Date:	Sat, 09 Oct 2010 20:44:19 +0200
From:	Avi Kivity <avi@...hat.com>
To:	Gleb Natapov <gleb@...hat.com>
CC:	kvm@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, mingo@...e.hu,
	a.p.zijlstra@...llo.nl, tglx@...utronix.de, hpa@...or.com,
	riel@...hat.com, cl@...ux-foundation.org, mtosatti@...hat.com
Subject: Re: [PATCH v6 07/12] Add async PF initialization to PV guest.

  On 10/08/2010 09:54 AM, Gleb Natapov wrote:
> >  >+
> >  >+static void kvm_guest_cpu_notify(void *dummy)
> >  >+{
> >  >+	if (!dummy)
> >  >+		kvm_guest_cpu_init();
> >  >+	else
> >  >+		kvm_pv_disable_apf(NULL);
> >  >+}
> >
> >  Why are you making decisions based on a dummy input?
> >
> >  The whole thing looks strange.  Use two functions?
> >
> What is so strange? Type of notification is passed as a parameter.
> The code that does this is just under the function. I can rename
> dummy to something else. Or make it two functions.

Two separate functions is simplest.

-- 
I have a truly marvellous patch that fixes the bug which this
signature is too narrow to contain.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/