linux-kernel - Re: [PATCH] forcedeth: reconfigure multicast packet filter only when needed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTimMRQ+cmoCJTjWeSga+YrGDCGiBOCp5rJK+vF3Q@mail.gmail.com>
Date:	Sat, 9 Oct 2010 22:46:44 +0200
From:	Jindřich Makovička <makovick@...il.com>
To:	Stephen Hemminger <shemminger@...tta.com>
Cc:	linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
	davem@...emloft.net, aabdulla@...dia.com, mditto@...gle.com
Subject: Re: [PATCH] forcedeth: reconfigure multicast packet filter only when needed

2010/10/9 Stephen Hemminger <shemminger@...tta.com>:
> On Sat, 9 Oct 2010 13:26:05 +0200
> Jindřich Makovička <makovick@...il.com> wrote:
>
>> +
>> +     /* current packet filter state */
>> +     u32 cur_pff;
>> +     u32 cur_addr[2];
>> +     u32 cur_mask[2];
>>  };
>
> No big deal, but couldn't you just put those temporary variables
> on the stack. and reread the current value before stopping.

Sure, this version should do the same (still untested, I don't have a
machine with nForce here at the moment). I just wanted to avoid more
NIC register accesses, but it's probably a premature optimization.

Regards,
-- 
Jindrich Makovicka

View attachment "forcedeth2.diff" of type "text/x-patch" (2001 bytes)