linux-kernel - Re: [PATCH 0/2] HID: hidraw, fix two NULL pointer dereferences

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101009144026.c37f8d25.ospite@studenti.unina.it>
Date:	Sat, 9 Oct 2010 14:40:26 +0200
From:	Antonio Ospite <ospite@...denti.unina.it>
To:	Jiri Slaby <jirislaby@...il.com>
Cc:	linux-input@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
	Alan Ott <alan@...nal11.us>,
	Oliver Neukum <oliver@...kum.name>,
	linux-kernel@...r.kernel.org, stable@...nel.org
Subject: Re: [PATCH 0/2] HID: hidraw, fix two NULL pointer dereferences

On Wed, 06 Oct 2010 12:09:07 +0200
Jiri Slaby <jirislaby@...il.com> wrote:

> On 10/06/2010 12:01 PM, Antonio Ospite wrote:
> > On Tue, 05 Oct 2010 23:12:00 +0200
> > Jiri Slaby <jirislaby@...il.com> wrote:
[...]
> >> Hi, please fix also the window in hidraw_release.
> >>
> > 
> > I am not sure I get what you mean, can you please add more details?
> 
> Sure. Look at the code:
> if (!hidraw_table[minor])
>         return -ENODEV;
> ...
> dev = hidraw_table[minor];
> if (!--dev->open) {
> ...
> 
> This is done without minors_lock, so you can easily have dev being NULL
> even though the first if.
>

Jiri (Slaby) I think it makes more sense if you send a patch about this
as it is you who has raised the issue.

Thanks,
   Antonio

-- 
Antonio Ospite
http://ao2.it

PGP public key ID: 0x4553B001

A: Because it messes up the order in which people normally read text.
   See http://en.wikipedia.org/wiki/Posting_style
Q: Why is top-posting such a bad thing?

Content of type "application/pgp-signature" skipped