linux-kernel - Re: [PATCH 2/3] Add Opticon OPN2001 write support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 10 Oct 2010 14:53:19 +0400
From:	Sergei Shtylyov <sshtylyov@...sta.com>
To:	Alon Ziv <alon+git@...aviz.org>
CC:	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] Add Opticon OPN2001 write support

Hello.

On 10-10-2010 10:32, Alon Ziv wrote:

> OPN2001 expects write operations to arrive as a vendor-specific command
> through the control pipe (instead of using a separate bulk-out pipe).

> Signed-off-by: Alon Ziv<alon-git@...aviz.org>
> ---
>   drivers/usb/serial/opticon.c |   30 ++++++++++++++++++++++++++----
>   1 files changed, 26 insertions(+), 4 deletions(-)

> diff --git a/drivers/usb/serial/opticon.c b/drivers/usb/serial/opticon.c
> index 9ff19c8..4fe7c3d 100644
> --- a/drivers/usb/serial/opticon.c
> +++ b/drivers/usb/serial/opticon.c
[...]
> @@ -237,10 +240,29 @@ static int opticon_write(struct tty_struct *tty, struct usb_serial_port *port,
>
>   	usb_serial_debug_data(debug,&port->dev, __func__, count, buffer);
>
> -	usb_fill_bulk_urb(urb, serial->dev,
> -			  usb_sndbulkpipe(serial->dev,
> -					  port->bulk_out_endpointAddress),
> -			  buffer, count, opticon_write_bulk_callback, priv);
> +	if (port->bulk_out_endpointAddress) {
> +		usb_fill_bulk_urb(urb, serial->dev,
> +				  usb_sndbulkpipe(serial->dev,
> +						  port->bulk_out_endpointAddress),
> +				  buffer, count, opticon_write_bulk_callback, priv);

    Please align all follow-up lines uniformly.

> +	} else {
> +		struct usb_ctrlrequest *dr;
> +
> +		dr = kmalloc(sizeof(struct usb_ctrlrequest), GFP_NOIO);

    sizeof(*dr) is a preferred form.

> +		usb_fill_control_urb(urb, serial->dev,
> +			usb_sndctrlpipe(serial->dev, 0),
> +			(unsigned char *)dr, buffer, count,
> +			opticon_write_bulk_callback, priv);

    More tabs needed for alignment, I think...

WBR, Sergei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/