[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 11 Oct 2010 00:09:36 +0900
From: Akinobu Mita <akinobu.mita@...il.com>
To: David Miller <davem@...emloft.net>
Cc: andy.grover@...cle.com, linux-kernel@...r.kernel.org,
linux-arch@...r.kernel.org, arnd@...db.de,
akpm@...ux-foundation.org, rds-devel@....oracle.com,
netdev@...r.kernel.org, Alexander Graf <agraf@...e.de>
Subject: Re: [PATCH 4/5] rds: stop including asm-generic/bitops/le.h directly
2010/10/9 David Miller <davem@...emloft.net>:
> From: Andy Grover <andy.grover@...cle.com>
> Date: Fri, 08 Oct 2010 11:55:55 -0700
>
>> On 10/08/2010 03:03 AM, Akinobu Mita wrote:
>>> asm-generic/bitops/le.h is only intended to be included directly from
>>> asm-generic/bitops/ext2-non-atomic.h or asm-generic/bitops/minix-le.h
>>> which implements generic ext2 or minix bit operations.
>>>
>>> This stops including asm-generic/bitops/le.h directly and use ext2
>>> non-atomic bit operations instead.
>>>
>>> An alternative approach is introducing little endian bit operations
>>> in linux/bitops.h. But it needs to touch more files than this change
>>> does.
>>
>>> - generic___set_le_bit(off, (void *)map->m_page_addrs[i]);
>>> + ext2_set_bit(off, (void *)map->m_page_addrs[i]);
>>
>> I'd like a solution that doesn't have rds calling a function starting
>> with ext2_. Seems wrong.
>
> Agreed.
OK, I'll rewrite the patch series to take the alternative approach.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists