linux-kernel - Re: [PATCH 0/3] Input: synaptics - multitouch and multifinger support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=VTq+3-t4taR_22E1Wkos+yeHdMDkHd-Zc9Cbs@mail.gmail.com>
Date:	Mon, 11 Oct 2010 08:41:44 -0500
From:	Chris Bagwell <chris@...bagwell.com>
To:	Henrik Rydberg <rydberg@...omail.se>
Cc:	Takashi Iwai <tiwai@...e.de>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Chase Douglas <chase.douglas@...onical.com>,
	linux-input@...r.kernel.org, xorg-devel@...ts.x.org,
	Andy Whitcroft <apw@...onical.com>,
	linux-kernel@...r.kernel.org,
	Peter Hutterer <peter.hutterer@...-t.net>,
	Duncan McGreggor <duncan.mcgreggor@...onical.com>
Subject: Re: [PATCH 0/3] Input: synaptics - multitouch and multifinger support

On Mon, Oct 11, 2010 at 2:48 AM, Henrik Rydberg <rydberg@...omail.se> wrote:
> On 10/11/2010 09:35 AM, Takashi Iwai wrote:
> [...]
>
>> In anyway, feel free to add my sign-off there since I already posted
>> my own one as a reference.
>>
>> But, I have an open issue with Chase's patch.  Maybe it's rather a
>> question to Henrik:
>>
>> Shouldn't all points be reported as ABS_MT_* events?  So far, only the
>> second touch-point is reported via ABS_MT_* while the first  point is
>> still reported as ABX_[X|Y].
>>
>> I corrected this in my patch I posted, but I wasn't sure, too.
>
>
> I have issues with all submitted patches, but did not give explicit reasons
> since there were overlapping submissions. Perhaps Chase and yourself can work
> out how you want to submit the new patches? And yes, all points should be
> reported as ABS_MT events.
>
> Thanks,
> Henrik
>

And is it also safe to say that we need to continue to report
ABS_X/ABS_Y *and* those values need to always track 1st finger touch
for backwards compatibility?

It was brought up in thread but not stated as strong requirement.

BTW, there are patches in last couple months to x86-input-synaptics
that will allow it to ignore jumps in values of ABS_X/ABS_Y when
transition of multi-touch occur (both adding or removing fingers via
BTN_TOOL_*TAP).  So one new-ish option is for ABS_X/ABS_Y to not track
1st finger but become average of 2 fingers.

Chris
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/