linux-kernel - Re: [PATCH] ext3: Use DIV_ROUND_UP() on group desc block counting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101011144529.GE3830@quack.suse.cz>
Date:	Mon, 11 Oct 2010 16:45:30 +0200
From:	Jan Kara <jack@...e.cz>
To:	Namhyung Kim <namhyung@...il.com>
Cc:	Jan Kara <jack@...e.cz>, Andrew Morton <akpm@...ux-foundation.org>,
	Andreas Dilger <adilger.kernel@...ger.ca>,
	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ext3: Use DIV_ROUND_UP() on group desc block counting

On Mon 11-10-10 19:38:39, Namhyung Kim wrote:
> Signed-off-by: Namhyung Kim <namhyung@...il.com>
  OK. Merged.

								Honza
> ---
>  fs/ext3/super.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/ext3/super.c b/fs/ext3/super.c
> index 75bbf77..3fce402 100644
> --- a/fs/ext3/super.c
> +++ b/fs/ext3/super.c
> @@ -1864,8 +1864,7 @@ static int ext3_fill_super (struct super_block *sb, void *data, int silent)
>  	sbi->s_groups_count = ((le32_to_cpu(es->s_blocks_count) -
>  			       le32_to_cpu(es->s_first_data_block) - 1)
>  				       / EXT3_BLOCKS_PER_GROUP(sb)) + 1;
> -	db_count = (sbi->s_groups_count + EXT3_DESC_PER_BLOCK(sb) - 1) /
> -		   EXT3_DESC_PER_BLOCK(sb);
> +	db_count = DIV_ROUND_UP(sbi->s_groups_count, EXT3_DESC_PER_BLOCK(sb));
>  	sbi->s_group_desc = kmalloc(db_count * sizeof (struct buffer_head *),
>  				    GFP_KERNEL);
>  	if (sbi->s_group_desc == NULL) {
> -- 
> 1.7.0.4
> 
-- 
Jan Kara <jack@...e.cz>
SUSE Labs, CR
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/