linux-kernel - Re: [PATCH v2] misc: adds support the FSA9480 USB Switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101011173649.GC7116@kroah.com>
Date:	Mon, 11 Oct 2010 10:36:49 -0700
From:	Greg KH <greg@...ah.com>
To:	Minkyu Kang <mk7.kang@...sung.com>
Cc:	linux-kernel@...r.kernel.org, linux-i2c@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>,
	kyungmin.park@...sung.com, Ben Dooks <ben-i2c@...ff.org>
Subject: Re: [PATCH v2] misc: adds support the FSA9480 USB Switch

On Mon, Oct 11, 2010 at 10:32:33AM +0900, Minkyu Kang wrote:
> The FSA9480 is a USB port accessory detector and switch.
> This patch adds support the FSA9480 USB Switch.
> 
> Signed-off-by: Minkyu Kang <mk7.kang@...sung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@...sung.com>
> ---
> v2:
>  use the threaded irq
>  fix the sysfs
> 
>  drivers/misc/Kconfig    |    9 +
>  drivers/misc/Makefile   |    1 +
>  drivers/misc/fsa9480.c  |  544 +++++++++++++++++++++++++++++++++++++++++++++++
>  include/linux/fsa9480.h |   40 ++++

Why do you need a .h file here for a single driver?

You are creating new sysfs files, so you are required to add a new
Documentation/ABI file as well, please add that to this patch.

And why are you exporting symbols from this driver, that should not be
needed at all.


> +/*
> + * fsa9480.c - FSA9480 micro USB switch device driver
> + *
> + * Copyright (C) 2010 Samsung Electronics
> + * Minkyu Kang <mk7.kang@...sung.com>
> + * Wonguk Jeong <wonguk.jeong@...sung.com>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License as published by
> + * the Free Software Foundation; either version 2 of the License, or
> + * (at your option) any later version.

Are you positive about that "any later version" portion of this?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/