linux-kernel - Re: [PATCH] x86, setup: Check early serial console per string instead of one char

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CB369E5.6040600@kernel.org>
Date:	Mon, 11 Oct 2010 12:47:49 -0700
From:	Yinghai Lu <yinghai@...nel.org>
To:	"H. Peter Anvin" <hpa@...or.com>
CC:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86, setup: Check early serial console per string instead
 of one char

On 10/11/2010 11:19 AM, H. Peter Anvin wrote:
> On 10/11/2010 10:50 AM, Yinghai Lu wrote:
>>
>> Move out serial_putchar() calling out of putchar
>> Let puts() to call serial_putchar() directly.
>>
>> So only need to check early_serial_base per string.
>>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>>
> 
> This seems to add a bunch of code for zero benefit.  Testing a global
> variable is zero cost compared to either a BIOS call or poking a serial
> port.

some server have bios serial console redirection support, and bios int call could send char to screen and serial port.

in that case, take out serial_putchar from putchar could produce more readable print out from serial console

Thanks

Yinghai
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/