| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <tkrat.dd9197843f6a0a54@s5r6.in-berlin.de> Date: Mon, 11 Oct 2010 23:39:46 +0200 (CEST) From: Stefan Richter <stefanr@...6.in-berlin.de> To: Tejun Heo <tj@...nel.org> cc: linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org Subject: Re: [PATCH] firewire: sbp2: parallelize login/inquiry, reconnect, and shutdown Stefan Richter wrote: > There are indeed situations where the last module reference was already > put down before the work is run for the last time. Thanks for the hint. > > What is preferable, an own workqueue instance whose destroy_workqueue() > lets sbp2_cleanup wait for unfinished work, or module ref-counting like > below? Anoher thing: Somebody might have swap space on a FireWire disk. Yet the system workqueues that firewire-core and (perhaps) firewire-sbp2 are using are created without WQ_RESCUER. Does this --- fringe use case as it might be --- call for private workqueues in firewire-core (for fw_device.work) and firewire-sbp2 (for sbp2_logical_unit.work)? Besides the less interesting cases of device discovery and shutdown, both of these works are also involved in SBP reconnect which needs to be performed at each FireWire bus reset (which can happen anytime for a variety of reasons). -- Stefan Richter -=====-==-=- =-=- -=-== http://arcgraph.de/sr/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists