linux-kernel - Re: [RFC PATCH] Staging: speakup: Added EXPORT_SYMBOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101011230017.GT4721@const.famille.thibault.fr>
Date:	Tue, 12 Oct 2010 01:00:17 +0200
From:	Samuel Thibault <samuel.thibault@...-lyon.org>
To:	Tracey Dent <tdent48227@...il.com>
Cc:	greg@...ah.com, w.d.hubbs@...il.com, chris@...-brannons.com,
	kirk@...ille.uwo.ca, linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH] Staging: speakup: Added EXPORT_SYMBOL_GPL() markings.

Tracey Dent, le Mon 11 Oct 2010 18:36:30 -0400, a écrit :
> -void speakup_clear_selection(void)
> -{
> -	sel_start = -1;
> -}

Mmm, this won't be so simple actually, as speakup_set_selection and
speakup_paste_selection will still be using speakup/selection.c's
sel_start variable.  I guess all speakup/selection.c will need to be
migrated to using drivers/char/selection.c functions at the same time.

speakup_paste_selection is basically like paste_selection, except that
it can be called with in_atomic() being true.  Yes, it's a hack.  The
calls to speakup_past_selection should first be moved to a helper
thread, and then the main paste_selection function can be used instead.

speakup_set_selection is basically like set_selection, except that it
doesn't take a userland structure, but gets the values from kernelland
speakup.  A kernel-land variant of set_selection should probably be
defined that takes a kernelland structure. Apart from that, I don't
think speakup_set_selection has anything particular compared to the main
version.  Kirk, can you confirm?

Samuel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/