linux-kernel - Re: [PATCH 1/1] ATM: mpc, fix use after free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1286787580.2737.4.camel@edumazet-laptop>
Date:	Mon, 11 Oct 2010 10:59:40 +0200
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	davem@...emloft.net, netdev@...r.kernel.org,
	linux-atm-general@...ts.sourceforge.net,
	linux-kernel@...r.kernel.org, jirislaby@...il.com
Subject: Re: [PATCH 1/1] ATM: mpc, fix use after free

Le lundi 11 octobre 2010 à 10:46 +0200, Jiri Slaby a écrit :
> Stanse found that mpc_push frees skb and then it dereferences it. It
> is a typo, new_skb should be dereferenced there.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Eric Dumazet <eric.dumazet@...il.com>
> ---
>  net/atm/mpc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/net/atm/mpc.c b/net/atm/mpc.c
> index 622b471..74bcc66 100644
> --- a/net/atm/mpc.c
> +++ b/net/atm/mpc.c
> @@ -778,7 +778,7 @@ static void mpc_push(struct atm_vcc *vcc, struct sk_buff *skb)
>  	eg->packets_rcvd++;
>  	mpc->eg_ops->put(eg);
>  
> -	memset(ATM_SKB(skb), 0, sizeof(struct atm_skb_data));
> +	memset(ATM_SKB(new_skb), 0, sizeof(struct atm_skb_data));
>  	netif_rx(new_skb);
>  }
>  

Acked-by: Eric Dumazet <eric.dumazet@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/