linux-kernel - Re: [PATCH] sched: drop all load weight manipulation for RT tasks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1286875876.29097.24.camel@twins>
Date:	Tue, 12 Oct 2010 11:31:16 +0200
From:	Peter Zijlstra <peterz@...radead.org>
To:	Linus Walleij <linus.walleij@...ricsson.com>
Cc:	Ingo Molnar <mingo@...e.hu>, linux-kernel@...r.kernel.org,
	Lennart Poettering <lennart@...ttering.net>, stable@...nel.org
Subject: Re: [PATCH] sched: drop all load weight manipulation for RT tasks

On Mon, 2010-10-11 at 16:36 +0200, Linus Walleij wrote:
> Load weights are for the CFS, they do not belong in the RT
> task. This makes all RT scheduling classes leave the
> CFS weights alone.
> 
> This fixes a real bug as well: I noticed the following
> phonomena: a process elevated to SCHED_RR forks with
> SCHED_RESET_ON_FORK set, and the child is indeed SCHED_OTHER,
> and the niceval is indeed reset to 0. However the
> weight inserted by set_load_weight() remains at 0. giving the
> task insignificat priority.
> 
> With this fix, the weight is reset to what the task had before
> being elevated to SCHED_RR/SCHED_FIFO.
> 
> Cc: Lennart Poettering <lennart@...ttering.net>
> Cc: stable@...nel.org
> Signed-off-by: Linus Walleij <linus.walleij@...ricsson.com>

Thanks, queued it up, we'll see if anything explodes ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/