linux-kernel - Re: [PATCH] security: move LSM xattrnames to xattr.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1286888769.2670.5.camel@localhost.localdomain>
Date:	Tue, 12 Oct 2010 09:06:09 -0400
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Ozan Çağlayan <ozan@...dus.org.tr>
Cc:	Steve Grubb <sgrubb@...hat.com>, James Morris <jmorris@...ei.org>,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	linux-fsdevel@...r.kernel.org,
	Casey Schaufler <casey@...aufler-ca.com>,
	David Safford <safford@...son.ibm.com>,
	Dave Hansen <dave@...ux.vnet.ibm.com>,
	Mimi Zohar <zohar@...ibm.com>
Subject: Re: [PATCH] security: move LSM xattrnames to xattr.h

On Tue, 2010-10-12 at 14:14 +0300, Ozan Çağlayan wrote:
> Cuma 02 Temmuz 2010 günü (saat 03:16:01) James Morris şunları yazmıştı:
> > On Thu, 1 Jul 2010, Mimi Zohar wrote:
> > > Make the security extended attributes names global. Updated to move
> > > the remaining Smack xattrs.
> > > 
> > > Signed-off-by: Mimi Zohar <zohar@...ibm.com>
> > > Acked-by: Serge Hallyn <serue@...ibm.com>
> > 
> 
> This drops 
> 
> #define XATTR_CAPS_SUFFIX "capability"
> #define XATTR_NAME_CAPS XATTR_SECURITY_PREFIX XATTR_CAPS_SUFFIX
> 
> definitions from capability.h and puts them in xattr.h's #ifdef __KERNEL__ 
> section making them invisible to userspace like libcap-ng causing build 
> failures.
> 
> Am I wrong?

You're correct.  It's the same reason that cap-ng.c has to define
'security'.

#ifdef VFS_CAP_U32
 #include <attr/xattr.h>
 #define XATTR_SECURITY_PREFIX "security."

Am cc'ing Steve.

Mimi

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/