linux-kernel - Re: [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8762x733qn.fsf@basil.nowhere.org>
Date:	Tue, 12 Oct 2010 16:06:08 +0200
From:	Andi Kleen <andi@...stfloor.org>
To:	Penttilä Mika <mika.penttila@...nos.com>
Cc:	"linux-kernel\@vger.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] HWPOISON: Implement hwpoison-on-free for soft offlining

Penttilä Mika <mika.penttila@...nos.com> writes:

Please always cc people when answering list emails.
Missed this earlier.

>> --- a/mm/page_alloc.c
>> +++ b/mm/page_alloc.c
>> @@ -564,6 +564,8 @@ static inline int free_pages_check(struct page *page)
>>  		(page->mapping != NULL)  |
>>  		(atomic_read(&page->_count) != 0) |
>>  		(page->flags & PAGE_FLAGS_CHECK_AT_FREE))) {
>> +		if (PageHWPoisonOnFree(page))
>> +			hwpoison_page_on_free(page);
>
> hwpoison_page_on_free() seems to be undefined when
> CONFIG_HWPOISON_ON_FREE is not defined.

The optimizer takes care of that.

>
>>  		bad_page(page);
>>  		return 1;
>>  	}
>
> And of course PAGE_FLAGS_CHECK_AT_FREE should include
> pahehwpoisononfree this to be effective

It is of course (__PG_HWPOISON_ON_FREE)

Thanks for the review.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/