linux-kernel - Re: [PATCH 13/23] x86/PCI: make sure _PAGE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101012085422.04b4e1c9@jbarnes-desktop>
Date:	Tue, 12 Oct 2010 08:54:22 -0700
From:	Jesse Barnes <jbarnes@...tuousgeek.org>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
Cc:	linux-kernel@...r.kernel.org, Jan Beulich <JBeulich@...ell.com>,
	xen-devel@...ts.xensource.com,
	Jeremy Fitzhardinge <jeremy@...p.org>,
	Konrad Rzeszutek Wilk <konrad@...nel.org>,
	Stefano Stabellini <stefano.stabellini@...citrix.com>,
	Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>,
	x86@...nel.org
Subject: Re: [PATCH 13/23] x86/PCI: make sure _PAGE_IOMAP it set on pci
 mappings

On Tue, 12 Oct 2010 11:44:21 -0400
Konrad Rzeszutek Wilk <konrad.wilk@...cle.com> wrote:

> From: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> 
> When mapping pci space via /sys or /proc, make sure we're really
> doing a hardware mapping by setting _PAGE_IOMAP.
> 
> [ Impact: bugfix; make PCI mappings map the right pages ]
> 
> Signed-off-by: Jeremy Fitzhardinge <jeremy.fitzhardinge@...rix.com>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> Reviewed-by: "H. Peter Anvin" <hpa@...or.com>
> Reviewed-by: Matthew Wilcox <willy@...ux.intel.com>
> Cc: x86@...nel.org
> Cc: Jesse Barnes <jbarnes@...tuousgeek.org>
> ---
>  arch/x86/pci/i386.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/x86/pci/i386.c b/arch/x86/pci/i386.c
> index 5525309..8379c2c 100644
> --- a/arch/x86/pci/i386.c
> +++ b/arch/x86/pci/i386.c
> @@ -311,6 +311,8 @@ int pci_mmap_page_range(struct pci_dev *dev, struct vm_area_struct *vma,
>  		 */
>  		prot |= _PAGE_CACHE_UC_MINUS;
>  
> +	prot |= _PAGE_IOMAP;	/* creating a mapping for IO */
> +
>  	vma->vm_page_prot = __pgprot(prot);
>  
>  	if (io_remap_pfn_range(vma, vma->vm_start, vma->vm_pgoff,

Looks fine.

Acked-by: Jesse Barnes <jbarnes@...tuousgeek.org>

-- 
Jesse Barnes, Intel Open Source Technology Center
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/