linux-kernel - Re: [PATCH 2/5] secmark: make secmark object handling generic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.01.1010121824540.15529@obet.zrqbmnf.qr>
Date:	Tue, 12 Oct 2010 18:26:24 +0200 (CEST)
From:	Jan Engelhardt <jengelh@...ozas.de>
To:	Eric Paris <eparis@...hat.com>
cc:	linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org,
	netfilter@...r.kernel.org, paul.moore@...com, jmorris@...ei.org,
	selinux@...ho.nsa.gov, sds@...ho.nsa.gov,
	linux-security-module@...r.kernel.org, mr.dash.four@...glemail.com,
	pablo@...filter.org
Subject: Re: [PATCH 2/5] secmark: make secmark object handling generic


On Tuesday 2010-10-12 17:40, Eric Paris wrote:
>diff --git a/include/linux/netfilter/xt_SECMARK.h b/include/linux/netfilter/xt_SECMARK.h
>index 6fcd344..989092b 100644
>--- a/include/linux/netfilter/xt_SECMARK.h
>+++ b/include/linux/netfilter/xt_SECMARK.h
>@@ -11,18 +11,12 @@
>  * packets are being marked for.
>  */
> #define SECMARK_MODE_SEL	0x01		/* SELinux */
>-#define SECMARK_SELCTX_MAX	256
>-
>-struct xt_secmark_target_selinux_info {
>-	__u32 selsid;
>-	char selctx[SECMARK_SELCTX_MAX];
>-};
>+#define SECMARK_SECCTX_MAX	256
> 
> struct xt_secmark_target_info {
> 	__u8 mode;
>-	union {
>-		struct xt_secmark_target_selinux_info sel;
>-	} u;
>+	__u32 secid;
>+	char secctx[SECMARK_SECCTX_MAX];
> };

If you make changes here, bump the .revision please, in here:

> static struct xt_target secmark_tg_reg __read_mostly = {
>-	.name       = "SECMARK",
>-	.revision   = 0,
>-	.family     = NFPROTO_UNSPEC,
>-	.checkentry = secmark_tg_check,
>-	.destroy    = secmark_tg_destroy,
>-	.target     = secmark_tg,
>-	.targetsize = sizeof(struct xt_secmark_target_info),
>-	.me         = THIS_MODULE,
>+	.name		= "SECMARK",
>+	.revision	= 0,
>+	.family		= NFPROTO_UNSPEC,
>+	.checkentry	= secmark_tg_check,
>+	.destroy	= secmark_tg_destroy,
>+	.target		= secmark_tg,
>+	.targetsize	= sizeof(struct xt_secmark_target_info),
>+	.me		= THIS_MODULE,
> };
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/