linux-kernel - Re: [RFC/PATCH 2/2] usb: Adding SuperSpeed support to dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <50cefd84a7623992aaa547f1476a67d4.squirrel@www.codeaurora.org>
Date:	Tue, 12 Oct 2010 11:07:04 -0700 (PDT)
From:	tlinder@...eaurora.org
To:	"Alan Stern" <stern@...land.harvard.edu>
Cc:	"Brokhman Tatyana" <tlinder@...eaurora.org>,
	linux-usb@...r.kernel.org,
	"David Brownell" <dbrownell@...rs.sourceforge.net>,
	"Greg Kroah-Hartman" <gregkh@...e.de>, linux-kernel@...r.kernel.org
Subject: Re: [RFC/PATCH 2/2] usb: Adding SuperSpeed support to dummy_hcd

> On Tue, 12 Oct 2010, Brokhman Tatyana wrote:

Hi Alan

I see your point. I'll update this in the next patch.

Thanks
Tanya

>> Hi Alan
>>
>> Thanks you for your comments. Please see my reply inline.
>
>> > In addition, I suspect the dummy_hcd driver structure shouldn't
>> contain
>> > an address_device entry.  It should be present only in dummy_ss_hcd.
>>
>> I'm not sure I follow...
>> According to the code and comments in hub.c address_device cb is used if
>> the host controller wishes to choose the device address itself instead
>> of
>> the address chosen by the core.
>
> Correct.
>
>>  It seems to me that there is nothing
>> preventing the dummy_hcd from supplying such cb as well. Is there?
>> Having both HS and SS dummy_hcd determine the device address seems more
>> convenient for testing proposes.
>
> For testing purposes, it is best to imitate the behavior of a real
> device as closely as possible.  USB-2.0 host controllers do not assign
> their own addresses to devices; they use the addresses provided by
> usbcore.  I think this is also true for the low/full/high-speed
> components of a USB-3.0 controller.
>
> Alan Stern
>
>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/