linux-kernel - Re: [PATCH] mmc: append a file to change host clock at run time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Oct 2010 11:15:20 +0300
From:	Andy Shevchenko <andy.shevchenko@...il.com>
To:	Adrian Hunter <adrian.hunter@...ia.com>
Cc:	"linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Chris Ball <cjb@...top.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	"Shevchenko Andriy (EXT-Teleca/Helsinki)" 
	<ext-andriy.shevchenko@...ia.com>
Subject: Re: [PATCH] mmc: append a file to change host clock at run time

On Wed, Oct 13, 2010 at 11:07 AM, Adrian Hunter <adrian.hunter@...ia.com> wrote:
>> +static int mmc_clock_opt_set(void *data, u64 val)
>> +{
>> +       struct mmc_host *host = data;
>> +
>> +       /* We need this check due to input value is u64 */
>> +       if (val>  host->f_max)
>> +               return -EINVAL;
>> +
>> +       mmc_set_clock(host, (unsigned int) val);
>
> Probably need to claim the host here otherwise you might
> be changing the clock while a request is in progress
Yeah, good catch. Will fix. Thanks.

-- 
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/