linux-kernel - Re: [PATCH update] firewire: core: use non-reentrant workqueue with rescuer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CB58020.6050707@kernel.org>
Date:	Wed, 13 Oct 2010 11:47:12 +0200
From:	Tejun Heo <tj@...nel.org>
To:	Stefan Richter <stefanr@...6.in-berlin.de>
CC:	linux1394-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org
Subject: Re: [PATCH update] firewire: core: use non-reentrant workqueue with
 rescuer

Hello,

On 10/12/2010 11:29 PM, Stefan Richter wrote:
...
> fw_card.br_work instances should not, and instances of the others must
> not, be executed in parallel by multiple CPUs -- but were not protected
> against that.  Hence allocated a non-reentrant workqueue for them.
> 
> fw_device.work may be used in the memory reclaim path in case of SBP-2
> device updates.  Hence we need a workqueue with rescuer and cannot use
> system_nrt_wq.
> 
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>

Looks good to me.

Reviewed-by: Tejun Heo <tj@...nel.org>

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/