linux-kernel - Re: [PATCH 07/18] fs: rework icount to be a locked variable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101013113643.GD19456@infradead.org>
Date:	Wed, 13 Oct 2010 07:36:43 -0400
From:	Christoph Hellwig <hch@...radead.org>
To:	Dave Chinner <david@...morbit.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/18] fs: rework icount to be a locked variable

> -		atomic_inc(&inode->i_count);
> +		spin_lock(&inode->i_lock);
> +		inode->i_ref++;
> +		spin_unlock(&inode->i_lock);

Why isn't this using iref?

> +		spin_lock(&inode->i_lock);
> +		inode->i_ref++;
> +		spin_unlock(&inode->i_lock);

Same here and in a couple of others.

Hmm, I guess because the i_lock later covers other things around.
But it still looks a bit weird.

Except for this stuff the patch looks good,


Reviewed-by: Christoph Hellwig <hch@....de>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/