linux-kernel - Re: [RFC PATCH 1/9] uaccess: Make copy_from_user

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101013144734.GB5335@nowhere>
Date:	Wed, 13 Oct 2010 16:47:36 +0200
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Ingo Molnar <mingo@...e.hu>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Stephane Eranian <eranian@...gle.com>,
	Cyrill Gorcunov <gorcunov@...nvz.org>,
	Tom Zanussi <tzanussi@...il.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Robert Richter <robert.richter@....com>
Subject: Re: [RFC PATCH 1/9] uaccess: Make copy_from_user_nmi() globally
	available

On Wed, Oct 13, 2010 at 09:15:56AM +0200, Peter Zijlstra wrote:
> On Wed, 2010-10-13 at 07:06 +0200, Frederic Weisbecker wrote:
> > In order to support user stack dump safely in perf samples from
> > generic code, export copy_from_user_nmi() from x86 and make it
> > generally available. For most archs it will map to
> > copy_from_user_inatomic, but for x86 we need to take care of
> > not faulting from NMIs.
> > 
> > Since perf is the first user for now, let the overriden x86
> > implementation in the perf source file.
> 
> It might make sense to call it copy_from_user_gup() because that's
> bascially what it does, it doesn't rely on NMI context anymore, its just
> NMI-safe.
> 
> Its a best effort software page table walk, and with the stacked
> kmap_atomic bits Andrew took it should work from any context.


Ok, I'll do the rename. Does that work on any arch?

Thanks.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/