linux-kernel - Re: [PATCH] sdio: fix suspend/resume regression

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <alpine.LFD.2.00.1010131559580.2764@xanadu.home>
Date:	Wed, 13 Oct 2010 16:00:55 -0400 (EDT)
From:	Nicolas Pitre <nico@...xnic.net>
To:	Vitaly Wool <vitalywool@...il.com>
Cc:	Ohad Ben-Cohen <ohad@...ery.com>, linux-mmc@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...e.de>,
	Maxim Levitsky <maximlevitsky@...il.com>,
	libertas-dev@...ts.infradead.org,
	Sven Neumann <s.neumann@...mfeld.com>,
	linux-kernel@...r.kernel.org, "Rafael J. Wysocki" <rjw@...k.pl>,
	Daniel Mack <daniel@...aq.de>,
	Colin Cross <ccross@...roid.com>, Chris Ball <cjb@...top.org>,
	stable@...nel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] sdio: fix suspend/resume regression

On Wed, 13 Oct 2010, Vitaly Wool wrote:

> Hi Ohad,
> 
> On Wed, Oct 13, 2010 at 9:31 AM, Ohad Ben-Cohen <ohad@...ery.com> wrote:
> 
> > diff --git a/drivers/mmc/core/core.c b/drivers/mmc/core/core.c
> > index c94565d..515ff39 100644
> > --- a/drivers/mmc/core/core.c
> > +++ b/drivers/mmc/core/core.c
> > @@ -1682,6 +1682,19 @@ int mmc_suspend_host(struct mmc_host *host)
> >        if (host->bus_ops && !host->bus_dead) {
> >                if (host->bus_ops->suspend)
> >                        err = host->bus_ops->suspend(host);
> > +               if (err == -ENOSYS || !host->bus_ops->resume) {
> > +                       /*
> > +                        * We simply "remove" the card in this case.
> > +                        * It will be redetected on resume.
> > +                        */
> > +                       if (host->bus_ops->remove)
> > +                               host->bus_ops->remove(host);
> > +                       mmc_claim_host(host);
> > +                       mmc_detach_bus(host);
> > +                       mmc_release_host(host);
> > +                       host->pm_flags = 0;
> > +                       err = 0;
> > +               }
> >        }
> >        mmc_bus_put(host);
> >
> 
> what about moving this logic to sdio bus_ops as this seems to be
> completely specific to sdio right now?

It doesn't have to.


Nicolas