Message-Id: <4CB5BF2B0200002300021BC2@novprvlin0050.provo.novell.com>
Date:	Tue, 12 Oct 2010 21:16:11 -0600
From:	"Joey Lee" <jlee@...ell.com>
To:	<chase.douglas@...onical.com>
Cc:	<rydberg@...math.org>, <chris@...bagwell.com>,
	<dmitry.torokhov@...il.com>, "Michael Chang" <MChang@...ell.com>,
	<tiwai@...e.de>, <linux-input@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <peter.hutterer@...-t.net>
Subject: Re: Proposal for synaptics driver

Add CC. Michael Chang

於 二，2010-10-12 於 16:11 -0400，Chase Douglas 提到：
> On Tue, 2010-10-12 at 13:41 -0500, Chris Bagwell wrote:
> > On Tue, Oct 12, 2010 at 11:23 AM, Chase Douglas
> > <chase.douglas@...onical.com> wrote:
> > > Hi all,
> > >
> > > There's been many patches and discussions on the synaptics MT work, so I
> > > wanted to gather thoughts into one thread to push things forward.
> > >
> > > First, I want to note something that I think has been overlooked. We've
> > > been talking about "ClickPad" devices quite a bit. One can find the
> > > product page for these devices at:
> > >
> > > http://www.synaptics.com/solutions/products/clickpad
> > >
> > > As a brief overview, ClickPads are an MT surface where the entire
> > > surface clicks. The click may be uniform over the touchpad, or it may be
> > > hinged on one of the edges. It appears that Takashi has figured out the
> > > appropriate bits in the extended capabilities flags to recognized a
> > > ClickPad. I can't confirm this, but it sounds like the device emits a
> > > middle mouse button click when the touchpad is depressed.
> > >
> > > Here's the confusing part: Synaptics has a different series of touchpads
> > > where only certain regions of the touchpad click. This is the case on my
> > > Dell Mini 1012. Unfortunately, I can't find any documentation for these
> > > touchpads on Synaptics' website. As another brief overview, my touchpad
> > > has two buttons integrated into the bottom ~20% of the touchpad. The
> > > left half of the button area clicks separately from the right half, and
> > > the device emits left and right buttons as appropriate. The rest of the
> > > touchpad is stationary and does not click. If no one has a better name
> > > for these touchpads, I'll refer to them as "integrated buttons"
> > > touchpads. Also unfortunately, I don't know which cap bits inform us of
> > > an integrated buttons touchpad, though I have suspicions it's bit
> > > 0x200000 of the 0c extended caps mask.
> > 
> > Ahh, that clears some things up to me.  Based on Takashi's
> > xf86-input-synaptic patches, it seems the click area is still in this
> > ~20% range even for clickpads.
> 
> Hmm, based on the synaptics product page I figured the click area of a
> ClickPad would be the entire surface. Takashi, do you have any input
> here? Maybe the ClickPad devices people have been using is of the hinged
> type, where it's easier to click on the bottom of the pad instead of the
> top?
> 
> > It sounds like the main difference
> > between clickpad's and "integrated button" touchpads is clickpads have
> > a way of reporting X/Y events in that click area *without* declaring
> > button press.
> 
> On my touchpad, the "embedded buttons" (what I'm calling "integrated
> buttons" now due to the name clash with the bcm5974 semantics) are touch
> sensitive, so the device still reports X/Y events no matter whether the
> button is depressed or not..
> 
> > If one really wanted to, this same clickpad behavior
> > could be emulated based on pressure but thats probably best for
> > userspace.  BTW, is there any pressure thresholds for your touchpad?
> 
> What do you mean by pressure thresholds? My device does report pressure.
> 
> > > Now onto implementation decisions. I feel that a kernel driver should
> > > provide a usable mouse without needing an X input module. There are
> > > projects like Wayland that don't use X, and I think people use gpm for
> > > consoles still. My definition of a usable mouse is single touch and left
> > > click support (including click and drag using a physical button).
> > >
> > > To answer another recurring question throughout the thread, other MT
> > > drivers send both ABS_MT_* and regular ABS_* events. One of the MT
> > > touches is assigned for single touch emulation at any given time. This
> > > supports legacy user space software that expects ST events while
> > > allowing for MT events to be used by more advanced software. I think we
> > > should do the sam> > > touch as Henrik suggested.
> > 
> > I haven't had time to review the code Henrik pointed to and don't
> > think exact behavior was spelled out in thread.  Since it applies to
> > my touchpad's, I'd like to state it briefly so we know how this rule
> > will be bent in later part of email.
> > 
> > I believe basic intent is to support ST emulation by continuing to
> > report the same touch for life of touch and if its released first the
> > emulation will revert to remaining tracked touch and advertise this
> > transition using BTN_TOOL_DOUBLETAP going from 1->0.
> 
> The way I implemented this in the hid-magicmouse driver for the Magic
> Trackpad is that the first finger touching the surface is the only ST
> emulated touch until all fingers are lifted off the device
> simultaneously. The following events illustrate the pattern:
> 
> 1. First finger goes down, gets ST emulation
> 2. Second finger goes down
> 3. First finger goes up, no ST emulation
> 4. Third finger does down, still no ST emulation
> 5. All fingers go up
> 6. First finger goes down, gets ST emulation
> etc.
> 
> I think this would work fine here as well, except for the scenario where
> two fingers start in the non-button area, and one moves to a button area
> and presses. The second finger would not control ST emulation, so no
> drags would be performed. I don't see this as an often seen scenario
> though.
> 
> More likely, a user would start with one finger over the button and the
> other in the non-button area. No matter which order of touch is
> performed, the above algorithm would work fine because the touch over
> the button area isn't figured into the ST emulation.
> 
> As for multifinger support (BTN_TOOL_DOUBLETAP, etc.), I was thinking
> that should be based on all touches whether they occur over a button
> area or not. However, if anyone has a convincing argument against this
> I'm happy to reconsider :).
> 
> BTW, ST emulation algorithms haven't been standardized. Some drivers can
> begin ST emulation on new touches while other touches are still present.
> 
> > > For ClickPad devices, my feeling is that we should translate middle
> > > button clicks to left button clicks in the kernel, and MT+ST emulation
> > > should be performed. Middle and right click functionality may be
> > > provided for in userspace, like in xf86-input-synaptics or through a
> > > gesture stack. I think this level of support meets my personal criteria
> > > for kernel level functionality specified above.
> > 
> > Agree.  I would consider click and drag as optional with ST emulation
> > but hopefully we can get it working with some thought.
> 
> What's the issue with ClickPad click and drag? I was thinking it should
> just work. The user touches the pad with one finger, depressing the
> ClickPad button. Now the left button depress event is emitted, and the
> user drags the finger.
> 
> > > Integrated buttons devices pose more of a challenge due to the need to
> > > properly support click and drag. Lets first assume that we can detect
> > > such a touchpad and determine the button area (I'll revisit this later).
> > > I think we should disable single touch support over the buttons due to
> > > the following scenario:
> > >
> > > User positions cursor over button on screen, attempts to click physical
> > > touchpad button, cursor moves because of motion on touchpad when user
> > > depresses button.
> > 
> > I think for this exact scenario its probably not needed but your in
> > best position to say.  I can do a button press-like touch on my
> > touchpad today with no cursor movement though.
> 
> Sadly I can't. I tried it for a few hours, but it just wasn't possible
> on my Dell Mini 1012 to click without moving while thinking about
> anything else at the same time :).
> 
> > Here is a close version of filtering ST when in click area that may or
> > may not be better option.  We could instead modify rule to track 1st
> > touch to track 1st touch unless its in click area and then prefer
> > > Let me try to convince myself that we won't see cursor jumps in X.
> > 1st touch in click area:
> > BTN_LEFT=1/BTN_TOUCH=1/ABS_X=1st_finger/ABS_Y=1st_finger.  2nd touch
> > in drag area:  BTN_TOOL_DOUBLETAP=1/ABS_X=2nd_finger/ABS_Y=2nd_finger.
> >  Release 2nd finger:
> > BTN_TOOL_DOUBLETAP=0/ABS_X=1st_finger/ABS_Y=1st_finger.
> > 
> > xf86-input-synaptics can handle those transitions without jumping.
> > Maybe not gpm or similar but should be small fixes to applications.
> 
> I hadn't thought of using BTN_TOOL_* as barriers across which the ST
> emulated touch could change. I'm concerned about legacy applications, as
> you noted, but if everyone feels this is a better resolution then I'm
> fine with it as well. I think it would allow for ST emulation across the
> entire touchpad surface of an "embedded buttons" device, until any
> buttons are depressed.
> 
> As an alternative, we could generate a dummy sequence for the
> transition:
> 
> First of two fingers goes to button area, then:
> BTN_TOUCH 0
> SYNC
> BTN_TOUCH 1
> ABS_X from second finger
> ABS_Y from second finger
> ABS_PRESSURE from second finger
> SYNC
> 
> The wrinkle I can envision here is that a quick first finger move from
> the non-button area to the button area will look like a tap because the
> BTN_TOUCH went down and up in a short period of time.
> 
> > This approach should allow click and drag to work and also allow ST
> > only applications to convert BTN_LEFT into left/middle/right as long
> > as it knows its an "integrated button" or "clickpad" touchpad.
> 
> "Embedded button" devices correctly report the appropriate button press
> because they have physically distinct buttons. I think this is merely an
> issue for ClickPads.
> 
> > BTW, I think both mouse movement issue and click and drag issue
> > applies to clickpad as well and so can use same decisions for it.
> 
> They might be. Once we play with it some we might find this to be the
> case.
> 
> > > However, we should support MT over the entire touchpad surface. Perhaps
> > > proper filtering and such could make the above scenario work better, and
> > > an advanced user space software, like xf86-input-synaptics, could listen
> > > to the MT events to get the data if it wants.
> > >
> > > Integrated buttons have ST emulation support, but only over the
> > > non-button area of the touchpad. If a touch moves over the button area,
> > > it disappears as far as ST-only aware software is concerned. ST
> > > emulation does not switch to another touch because that would look like
> > > a dragged touch. Since a touch beginning over the button area is never
> > > sent through ST emulation, click and drag will always work no matter
> > > which touch goes down first.
> > 
> > Do you know if hardware is doing any filtering?  For example, if you
> > move 1 finger from middle to click area does it do simple thing and
> > start reporting button press?  If it is filtering then that may change
> > the story a little.
> 
> I'm not sure I understand the question. On my laptop, it emits the
> appropriate button presses when the button is physically depressed. It
> also emits X/Y values whether the button is depressed or not. I'm not
> sure what filtering you may be referring to.
> 
> > I think both filtering approach and "prefer non-click touch" approach
> > allow click-and-drag.  If you do something like 2 finger touch in
> > center and move tracked finger into click area then it would need to
> > start reporting other touch and turn into a click-and-drag operation.
> > This ST tracking switch shouldn't seem different to user space then
> > case of user releasing tracked finger and moving to click area I
> > think.  Since BTN_TOOL_DOUBLETAP will go from 1 to 0 in both these
> > cases, user space has something to understand tracking switch.
> 
> I think we're in agreement on everything except for the possibility of
> using BTN_TOOL_* to distinguish between ST emulation touch switches. The
> BTN_TOOL_* switch could allow full ST > an "embedded buttons" trackpad until a button is pressed, but might
> slightly break legacy clients like gpm. Again, I'm open to both options,
> so if anyone feels particularly strong about this please speak up :).
> 
> Thanks for the feedback Chris!
> 
> -- Chase
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists