| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Wed, 13 Oct 2010 15:07:40 +1100 (EST) From: James Morris <jmorris@...ei.org> To: Eric Paris <eparis@...hat.com> cc: linux-kernel@...r.kernel.org, netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org, paul.moore@...com, selinux@...ho.nsa.gov, sds@...ho.nsa.gov, jengelh@...ozas.de, linux-security-module@...r.kernel.org, mr.dash.four@...glemail.com, pablo@...filter.org Subject: Re: [PATCH 1/5] secmark: do not return early if there was no error On Tue, 12 Oct 2010, Eric Paris wrote: > On Wed, 2010-10-13 at 10:38 +1100, James Morris wrote: > > On Tue, 12 Oct 2010, Eric Paris wrote: > > > > > Commit 4a5a5c73 attempted to pass decent error messages back to userspace for > > > netfilter errors. In xt_SECMARK.c however the patch screwed up and returned > > > on 0 (aka no error) early and didn't finish setting up secmark. This results > > > in a kernel BUG if you use SECMARK. > > > > > > > Does this need to go into current Linus? > > It's been broken since v2.6.35-rc1 so it's not exactly new, but yes, > it's broken and will bug like this in current Linus. Acked-by: James Morris <jmorris@...ei.org> (Guessing this should go in via the networking tree). -- James Morris <jmorris@...ei.org> -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists