linux-kernel - Re: [PATCH 1/1] mfd: Add TPS658621C device ID

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 13 Oct 2010 08:04:00 +0200
From:	Mike Rapoport <mike@...pulab.co.il>
To:	Samuel Ortiz <sameo@...ux.intel.com>
CC:	Andrew Chew <AChew@...dia.com>,
	"axel.lin@...il.com" <axel.lin@...il.com>,
	Gary King <GKing@...dia.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	'Greg KH' <greg@...ah.com>
Subject: Re: [PATCH 1/1] mfd: Add TPS658621C device ID

Samuel,

Can you please queue this?


Andrew Chew wrote:
> Sending again.  Can someone review for commit?
> 
> This is a really simple change that adds a new valid device ID for the existing tps6586x PMU driver.
> 
> The interface for this device should be identical to that of the
> TPS658521A.
> 
> Signed-off-by: Andrew Chew <achew@...dia.com>

Acked-by: Mike Rapoport <mike@...pulab.co.il>

> ---
>  drivers/mfd/tps6586x.c |    4 +++-
>  1 files changed, 3 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/tps6586x.c b/drivers/mfd/tps6586x.c
> index 117eb7c..b4931ab 100644
> --- a/drivers/mfd/tps6586x.c
> +++ b/drivers/mfd/tps6586x.c
> @@ -47,6 +47,7 @@
>  /* device id */
>  #define TPS6586X_VERSIONCRC	0xcd
>  #define TPS658621A_VERSIONCRC	0x15
> +#define TPS658621C_VERSIONCRC	0x2c
>  
>  struct tps6586x_irq_data {
>  	u8	mask_reg;
> @@ -497,7 +498,8 @@ static int __devinit tps6586x_i2c_probe(struct i2c_client *client,
>  		return -EIO;
>  	}
>  
> -	if (ret != TPS658621A_VERSIONCRC) {
> +	if ((ret != TPS658621A_VERSIONCRC) &&
> +	    (ret != TPS658621C_VERSIONCRC)) {
>  		dev_err(&client->dev, "Unsupported chip ID: %x\n", ret);
>  		return -ENODEV;
>  	}


-- 
Sincerely yours,
Mike.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/